-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #145, updating ci_lab to use new versioning system. #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbaker
force-pushed
the
fix-145
branch
5 times, most recently
from
December 26, 2023 15:54
af70d21
to
b9f7a64
Compare
dzbaker
commented
Jan 11, 2024
fsw/src/ci_lab_version.h
Outdated
@@ -36,14 +38,19 @@ | |||
#define CI_LAB_MINOR_VERSION 3 /*!< @brief Minor version number */ | |||
#define CI_LAB_REVISION 99 /*!< @brief Revision version number. Value of 99 indicates a development version.*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REVISION should be 0 instead of MISSION_REV being 00. Can use to set version string to development vs release.
dzbaker
added
CCB:Approved
Indicates code approval by CCB
and removed
CCB:Provisionally-Approved
labels
Jan 17, 2024
dzbaker
force-pushed
the
fix-145
branch
2 times, most recently
from
January 17, 2024 18:20
6ceb28c
to
2b0c488
Compare
dzbaker
added a commit
that referenced
this pull request
Jan 18, 2024
Fix #145, updating ci_lab to use new versioning system.
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 18, 2024
*Combines:* ci_lab equuleus-rc1+dev51 cFE equuleus-rc1+dev79 osal equuleus-rc1+dev37 **Includes:** *ci_lab* - nasa/ci_lab#162 - nasa/ci_lab#171 *cFE* - nasa/cFE#2494 *osal* - nasa/osal#1436 Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Andrew Hatstat <ahatstat@users.noreply.github.com> Co-authored by: Dylan Baker <dzbaker@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 18, 2024
*Combines:* ci_lab equuleus-rc1+dev51 cFE equuleus-rc1+dev79 osal equuleus-rc1+dev37 **Includes:** *ci_lab* - nasa/ci_lab#162 - nasa/ci_lab#171 *cFE* - nasa/cFE#2494 *osal* - nasa/osal#1436 Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Andrew Hatstat <ahatstat@users.noreply.github.com> Co-authored by: Dylan Baker <dzbaker@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jan 18, 2024
*Combines:* ci_lab equuleus-rc1+dev51 cFE equuleus-rc1+dev79 osal equuleus-rc1+dev37 **Includes:** *ci_lab* - nasa/ci_lab#162 - nasa/ci_lab#171 *cFE* - nasa/cFE#2494 *osal* - nasa/osal#1436 Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Andrew Hatstat <ahatstat@users.noreply.github.com> Co-authored by: Dylan Baker <dzbaker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #145.
Testing performed
Workflows were run.
Expected behavior changes
No behavior changes, however the following changes were made to the versioning system:
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Dylan Z. Baker/NASA GSFC